xds: use google default creds #3673
Merged
+47
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So the client works not only on GCE (e.g. it also read env variable for creds).
easwars
approved these changes
Jun 9, 2020
easwars
reviewed
Jun 9, 2020
credentials/google/google.go
Outdated
| @@ -31,7 +31,7 @@ import ( | |||
| "google.golang.org/grpc/internal" | |||
| ) | |||
|
|
|||
| const tokenRequestTimeout = 30 * time.Second | |||
| const tokenRequestTimeout = 3 * time.Second | |||
menghanl
force-pushed
the
xds_google_default_creds
branch
from
b88ebbd
to
4f9aee7
Compare
|
The leak is caused by I'm going to update leadcheck to ignore this goroutine. |
…d disable leakcheck" This reverts commit f3ffd29.
…nly disabling part of it doesnt work, because another test still see the leak
Check scope and do different things.
|
This PR now also changes gRPC's google default creds to skip oauth if scope is not set. Please take a look again. |
easwars
reviewed
Jun 10, 2020
| @@ -58,19 +56,11 @@ var ( | |||
| } | |||
| ) | |||
|
|
|||
| type s struct { | |||
There was a problem hiding this comment.
Could we please add a TODO here to re-add the leak check once the leak is fixed upstream.
menghanl
force-pushed
the
xds_google_default_creds
branch
from
98d25c7
to
de690bc
Compare
It panics on appgine with go1.9
And I looked at them at they seemed sane. You left off the surprising part! (That I actually, promptly, looked at it and replied.) |
menghanl
force-pushed
the
xds_google_default_creds
branch
from
de690bc
to
e16fab6
Compare
menghanl
commented
Jun 10, 2020
| @@ -1,3 +1,5 @@ | |||
| // +build !appengine | |||
There was a problem hiding this comment.
This test is disabled for appengine, because of https://travis-ci.org/github/grpc/grpc-go/jobs/697000659#L525
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use google default creds, so the client works not only on GCE (e.g. it also read env variable for creds).
Change google default creds to use jwt directly if scope is not set.
Leak check is disabled temporarily due to compute/metadata: goroutine leak googleapis/google-cloud-go#2417